lint: add lefthook, prettier, typos#481
Conversation
Deploying interrupt with
|
| Latest commit: |
a347d91
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2ae16d13.interrupt.pages.dev |
| Branch Preview URL: | https://noahp-lefthook.interrupt.pages.dev |
gminn
left a comment
gminn
left a comment
There was a problem hiding this comment.
Thank you so much for adding this! been wanting it for a while ❤️ Can't wait to open the massive formatting and typos fixing PR 💥
Install from npm, because it's simpler, so use lefthook as the pre-commit runner (`yarn install` automatically installs the hooks, which is somewhat nice too). I removed the reference to the `grammarly` vscode extension, since it's no longer available in the marketplace and the github repo is archived.
gminn
force-pushed
the
noahp/lefthook
branch
from
254461a to
2b68425
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds linting infrastructure to the repository by introducing lefthook as a pre-commit hook runner, prettier for markdown formatting, and typos-rs for spell checking. The PR also removes the deprecated Grammarly VSCode extension configuration and updates documentation to reflect the new setup requirements.
Key Changes:
- Adds lefthook, prettier, and typos-rs as npm dependencies with pre-commit hook configuration
- Removes deprecated Grammarly VSCode extension settings and replaces with prettier configuration
- Updates README with instructions for installing yarn dependencies and running linters
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Adds lockfile with lefthook 1.6.16, prettier 3.3.2, and typos-rs-npm dependencies |
| package.json | Defines npm scripts for linting and declares project dependencies |
| lefthook.yml | Configures pre-commit hooks to run prettier and typos on staged markdown files |
| _typos.toml | Provides configuration file for typos spell checker |
| .vscode/settings.json | Removes Grammarly settings and configures prettier as the default markdown formatter |
| .gitignore | Adds node_modules and Yarn 2 specific directories to ignore list |
| .gitattributes | Adds git attributes configuration for binary lockfile handling |
| readme.md | Updates documentation with yarn installation instructions and reformats text with line wrapping |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gminn
force-pushed
the
noahp/lefthook
branch
from
7d3e415 to
a347d91
Compare
|
Got this branch building again 💪 I also confirmed that the lefthook The error from build logs was: Changes I made to fix it:
|
Install from npm, because it's simpler, so use lefthook as the
pre-commit runner (
yarn installautomatically installs the hooks,which is somewhat nice too).
I removed the reference to the
grammarlyvscode extension, since it'sno longer available in the marketplace and the github repo is archived.